[Auto-affectation] Mettre en place un simulateur #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numew
requested review from
hmeneuvrier,
emilschn and
sfinx13
and removed request for
hmeneuvrier
hmeneuvrier
force-pushed
the
bugfix/3582-auto-affectation-partners-prefiltered-perimeter-geo
branch
from
44eb599 to
007eeaa
Compare
numew
force-pushed
the
feature/3590-auto-assigner-simulator
branch
from
cf74b76 to
9255254
Compare
emilschn
reviewed
Jan 27, 2025
| } | ||
| $signalements = $signalementRepository->findBy($criteria, ['createdAt' => 'DESC'], $limit); | ||
| foreach ($signalements as $signalement) { | ||
| $autoAssigner->assign($signalement, true); |
There was a problem hiding this comment.
Je trouve bizarre d'utiliser les deux méthodes.
Ici, j'utiliserais simplement la méthode get (qu'il faut modifier en conséquence)
Et la méthode assign appelle la méthode get en interne ?
There was a problem hiding this comment.
Ok, j'ai adapté le code
hmeneuvrier
force-pushed
the
bugfix/3582-auto-affectation-partners-prefiltered-perimeter-geo
branch
from
007eeaa to
4c2cf65
Compare
numew
force-pushed
the
feature/3590-auto-assigner-simulator
branch
from
9255254 to
d85c9e1
Compare
hmeneuvrier
reviewed
Jan 28, 2025
hmeneuvrier
force-pushed
the
bugfix/3582-auto-affectation-partners-prefiltered-perimeter-geo
branch
from
d6e299d to
095db40
Compare
numew
force-pushed
the
feature/3590-auto-assigner-simulator
branch
from
d85c9e1 to
9040e9f
Compare
numew
changed the base branch from
bugfix/3582-auto-affectation-partners-prefiltered-perimeter-geo
to
develop
hmeneuvrier
reviewed
Jan 29, 2025
| $signalements = $signalementRepository->findBy($criteria, ['createdAt' => 'DESC'], $limit); | ||
| foreach ($signalements as $signalement) { | ||
| $assignablePartners = $autoAssigner->assign($signalement, true); | ||
| dump($assignablePartners); |
There was a problem hiding this comment.
tiens... un dump ! :D
|
hmeneuvrier
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3590
Description
Mise en place d'un outil permettant de simuler le traitement d'auto affectation
limit=100, il est aussi possible de recherche un signalement particulier sur le territoire via l'url ex :uuid=blabla)Tests